Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

AGENT-94 Cleanup install script#281

Merged
pec1985 merged 16 commits intomainfrom
AGENT-94
May 8, 2025
Merged

AGENT-94 Cleanup install script#281
pec1985 merged 16 commits intomainfrom
AGENT-94

Conversation

@pec1985
Copy link
Copy Markdown
Contributor

@pec1985 pec1985 commented May 6, 2025 •
edited
Loading

  • Cleanup
  • Remove Windows support
  • Quick testing via docker, using make test_install_linux in the root of the dir
  • Updated README

The git diff is ugly, better to pull and check

TODO to merge:

  • update docs
  • update README
  • update website

jhaynie
jhaynie suggested changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jhaynie jhaynie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. having @Huijiro help test once ready on his linux setup would be good too!

Comment thread install.sh
Comment thread install.sh Outdated
Comment thread install.sh Outdated
@pec1985 pec1985 marked this pull request as ready for review May 7, 2025 19:36
@Huijiro
Copy link
Copy Markdown
Member

Huijiro commented May 7, 2025

How would I test this?

@pec1985
Copy link
Copy Markdown
Contributor Author

pec1985 commented May 7, 2025

How would I test this?

Pull the changes, and run ./install.sh, there are some variation, you can run ./install.sh -h to see the options. But mainly take a look at -d and -v. Make sure the script uses the "dir" and "version" passed in, and make sure it fails if it can't install.

@Huijiro
Copy link
Copy Markdown
Member

Huijiro commented May 7, 2025

image

Both build and the install script ran just fine on my machine.

I don't know if there's more to test here.

@pec1985 pec1985 requested review from Huijiro and jhaynie May 7, 2025 22:10
jhaynie
jhaynie suggested changes May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jhaynie jhaynie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we're using windows-latest now so we can remove from the matrix?

jhaynie
jhaynie suggested changes May 8, 2025
View reviewed changes
Comment thread Makefile
Comment thread README.md Outdated
@pec1985
Copy link
Copy Markdown
Contributor Author

pec1985 commented May 8, 2025

windows-latest

We are still using windows-latest for testing "go build" stuff. I tested all the go scripts in Windows (just as they are in the github action) and it's all working well

@pec1985 pec1985 requested a review from jhaynie May 8, 2025 13:54
jhaynie
jhaynie suggested changes May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jhaynie jhaynie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to remove the goreleaser wix step too.

image

you should install goreleaser-pro (via homebrew)

and you can test locally:

goreleaser release --snapshot --clean

jhaynie
jhaynie approved these changes May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jhaynie jhaynie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on this one! 💯 🚀 🤖

@pec1985 pec1985 merged commit d2c0758 into main May 8, 2025
14 checks passed
@pec1985 pec1985 deleted the AGENT-94 branch May 8, 2025 14:56
@devin-ai-integration devin-ai-integration Bot mentioned this pull request May 8, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Huijiro Huijiro Awaiting requested review from Huijiro

1 more reviewer

@jhaynie jhaynie jhaynie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pec1985 @Huijiro @jhaynie